Fix VersionRange crash on not in range versions - #29
Merged
Conversation
Earlier, the check for whether the pairwise version constraints is in a valid sequence and if the given version is in that pairwise range was performed in a single condition. Upon failing the later case, it assumed the failure of earlier as well and crashed. Now, the later check is performed within the former condition. Also, the check for != before looking for any constraint with a "=" avoids matching "!=" in the later case. Fixes: #25 Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14
force-pushed
the
fix/version_range_crash
branch
from
January 14, 2022 08:56
0ae59a0 to
0bd9162
Compare
Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Hritik14
force-pushed
the
fix/version_range_crash
branch
from
January 14, 2022 13:18
9b762c9 to
0d37220
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, the check for whether the pairwise version constraints is in a
valid sequence and if the given version is in that pairwise range was
performed in a single condition. Upon failing the later case, it assumed
the failure of earlier as well and crashed.
Now, the later check is performed within the former condition.
Also, the check for != before looking for any constraint with a "="
avoids matching "!=" in the later case.
Fixes: #25
Signed-off-by: Hritik Vijay hritikxx8@gmail.com